feat: add features in get-dependent-files.ts #1525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let fileBaseName = path.basename(fileName, '.ts'); | ||
| return files | ||
| .filter((file) => { | ||
| if (path.extname(path.basename(file, '.ts')) === '.spec') { |
There was a problem hiding this comment.
I think that getDependentFiles shouldn't lie to you. Return the spec here as well, and filter it out when you're actually using it.
ashoktamang
force-pushed
the
dependent-files
branch
6 times, most recently
from
4b8f613 to
cd02683
Compare
| * @return absolute paths of '.html/.css/.sass/.spec.ts' files associated with the given file. | ||
| * | ||
| */ | ||
| export function getAllCorrespondingFiles(fileName: string): Promise<string[]> { |
There was a problem hiding this comment.
Should we validate in here that the file is actually a .component file?
|
LGTM pending 2 comments. |
ashoktamang
force-pushed
the
dependent-files
branch
2 times, most recently
from
52bd322 to
823e53e
Compare
| @@ -75,6 +75,35 @@ export function hasIndexFile(dirPath: string): Promise<Boolean> { | |||
| } | |||
|
|
|||
| /** | |||
| * Function to get all the templates, stylesheets, and spec files of a given component unit | |||
| * Assumption: When any component/service/pipe unit is generated, Angular CLI has a blueprint for | |||
| * creating associated files with the name of the generated unit. So, there are two | |||
There was a problem hiding this comment.
will 2 spaces under 'Assumption: ' do?
ashoktamang
force-pushed
the
dependent-files
branch
4 times, most recently
from
aaf1d5b to
a32f7b9
Compare
add logic to filter out spec file associated with the given component unit and all index files while getting all dependent files add utlity function to get all the files (.html/stylesheets/.spec.ts) associated with the given component unit change the constructor method of the class ModuleResolver (add 'rootPath' as an additional parameter)
ashoktamang
force-pushed
the
dependent-files
branch
from
a32f7b9 to
77a7662
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add logic to filter out spec file associated with the given component unit and all index files while getting all dependent files
add utlity function to get all the files (.html/stylesheets/.spec.ts) associated with the given component unit
change the constructor method of the class ModuleResolver (add 'rootPath' as an additional parameter)